feat: support RSC #1582
Merged
feat: support RSC #1582
+311
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
amje
reviewed
Jun 10, 2024
| @@ -8,50 +8,50 @@ export function CheckboxShowcase() { | |||
| return ( | |||
| <Showcase> | |||
| <ShowcaseItem title="Size"> | |||
| <p> | |||
| <div style={{marginBlock: '1em'}}> | |||
| @@ -38,7 +34,7 @@ export const ControlLabel = React.forwardRef<HTMLLabelElement, Props>( | |||
| className={b({size, disabled}, className)} | |||
| data-qa={qa} | |||
| > | |||
| {clonedControl} | |||
| <div className={b('indicator')}>{control}</div> | |||
There was a problem hiding this comment.
This will result in different markup, is it ok?
|
Visual Tests Report is ready. |
amje
approved these changes
Jun 13, 2024
ValeraS
requested review from
IsaevAlexandr,
ogonkov,
korvin89,
sofiushko,
Raubzeug,
zamkovskaya,
Arucard89,
mournfulCoroner,
kseniya57,
jhoncool,
NikitaCG,
Estasie,
goshander,
d3m1d0v,
axtk,
SeqviriouM,
Lunory and
DakEnviy
as code owners
ogonkov
reviewed
Jun 13, 2024
| return ( | ||
| <div className={b({size})} ref={ref}> | ||
| <div className={b({size})}> |
There was a problem hiding this comment.
Isn't it a breaking change?
There was a problem hiding this comment.
No, it's inner component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.